New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add rich container mode #767
Merged
Letty5411
merged 11 commits into
AliyunContainerService:master
from
wangforthinker:dev-rich-container-v1
Feb 27, 2018
Merged
feature: add rich container mode #767
Letty5411
merged 11 commits into
AliyunContainerService:master
from
wangforthinker:dev-rich-container-v1
Feb 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
…by spec Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
Signed-off-by: allen.wang <allen.wq@alipay.com>
ping @wangforthinker CI fails according integration system. If this is flaky test, welcome to track this with profiling an issue. build url: https://travis-ci.org/alibaba/pouch/builds/346668411 |
the fail test is flaky test, unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Describe what this PR did
In pouch, we can start container in rich container mode by cli flag or API.
If by pouch client, we can set --rich flag to set rich container mode, and set --rich-mode to select which manner to init container, we support systemd, /sbin/init and dumb-init to init container.
If set dumb-init to init container, please install dumb-init in machines, https://github.com/Yelp/dumb-init/tree/v1.2.1
if set systemd or /sbin/init, we need to install systemd or /sbin/init in image.
Otherwise, we need to install runc modified by us to support it, referring to https://github.com/alibaba/runc/tree/v1.0.0-rc4-1.
2.Does this pull request fix one issue?
fixes #25
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews