Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a pouch version testcase #98

Merged
merged 1 commit into from
Nov 15, 2017
Merged

test: add a pouch version testcase #98

merged 1 commit into from
Nov 15, 2017

Conversation

sunyuan3
Copy link
Contributor

Signed-off-by: Yuan Sun yile.sy@alibaba-inc.com

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @sunyuan3
While we thought PR Description could be more specific, longer than 100 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@allencloud
Copy link
Collaborator

Actually I like this integration test case.

While CI fails:

----------------------------------------------------------------------
FAIL: pouch_cli_version_test.go:23: PouchVersionSuite.TestPouchVersion
pouch_cli_version_test.go:25:
    c.Assert(err, check.IsNil)
... value *exec.Error = &exec.Error{Name:"pouch", Err:(*errors.errorString)(0xc42000e410)} ("exec: \"pouch\": executable file not found in $PATH")
OOPS: 2 passed, 1 FAILED
--- FAIL: Test (0.00s)
FAIL
FAIL	github.com/alibaba/pouch/test	0.004s

)

// PouchVersionSuite is the test suite fo help CLI.
type PouchVersionSuite struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still be confused about how this suite works. Please next time you could share a little bit with us about how to add integration test via suite in Golang. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. The way to add integration test case need to be added in document. I will add integration test demo in CI. Then I will create a document.

Signed-off-by: Yuan Sun <yile.sy@alibaba-inc.com>
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 15, 2017
@allencloud allencloud merged commit 42488bf into AliyunContainerService:master Nov 15, 2017
@allencloud allencloud deleted the version branch November 15, 2017 06:01
@sunyuan3 sunyuan3 mentioned this pull request Nov 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants