Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Selection Should Reload #163

Closed
tsawyer opened this issue Sep 2, 2023 · 8 comments
Closed

Menu Selection Should Reload #163

tsawyer opened this issue Sep 2, 2023 · 8 comments

Comments

@tsawyer
Copy link
Member

tsawyer commented Sep 2, 2023

When on a menu item's page, selecting the menu item again should reload the page. As it is now it does nothing. This behavior is particularly unfriendly on small screens as you are left with only the menu if you select the same item. That's because the menu takes up the full screen on small devices.

@jxmx
Copy link
Member

jxmx commented Sep 3, 2023

@tsawyer Is your interest in just having the menu disappear if you happen to click on the same node, or to actually force a page reload? There's no technical action required of a browser when you click on its same node entry in the menu so it doesn't do anything.

@tsawyer
Copy link
Member Author

tsawyer commented Sep 4, 2023

It seems unusual and unexpected for a page (any page) to not load when selecting it's menu item. But however you choose to address the problem is up to you.

@jxmx
Copy link
Member

jxmx commented Sep 4, 2023

@tsawyer I'll force the page to reload. Since this the link points back to itself already in the form of index.html#node there isn't really the expectation for the page to reload syntactically. However I get your point of user expectations.

@jxmx jxmx closed this as completed in e2f8d92 Sep 5, 2023
@tsawyer
Copy link
Member Author

tsawyer commented Sep 5, 2023

All good except it doesn't work on the home button.

web.ini clip:

; Link the "Home" button will open. This is useful
; for filtering back down to an intial list of nodes
; rather than "all nodes"
HOME_BUTTON_URL = "index.html#2530,27439,28020"

@tsawyer tsawyer reopened this Sep 5, 2023
@tsawyer
Copy link
Member Author

tsawyer commented Sep 5, 2023

Voters alternately return a API error... 1st click ie ok, second click errors, 3 click is ok... repeats.

Screenshot 2023-09-05 at 10 11 29 AM

@jxmx
Copy link
Member

jxmx commented Sep 5, 2023

Yeah. This is a bit ugly because I'm trying to subvert the expected browser behavior of not reloading a page + anchors when you're already at that location. I'll have to think about this one some more.

jxmx added a commit that referenced this issue Sep 5, 2023
@jxmx
Copy link
Member

jxmx commented Sep 5, 2023

c4ed732

@jxmx
Copy link
Member

jxmx commented Sep 5, 2023

Finally fixed in c4ed732..7abd497

@jxmx jxmx closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants