Add Samples #320
Add Samples #320
Conversation
There was a problem hiding this comment.
I'm thinking you may have just copied everything in the rpt dir here and that isn't the point of the samples. I left some comments on things to adjust here. In general, each file here should be able to stand on its own, if you have me the sample file and the module, that should be enough to get it up and running in any configuration I might want.
| gain = 3 ; Antenna Gain | ||
| dir = 0 ; Antenna Direction | ||
|
|
||
| ; ehlert = |
There was a problem hiding this comment.
These settings are missing documentation.
There was a problem hiding this comment.
I'm not familiar with this module. Need input from others.
Add sample files to configs. Closes issues #312 and #316 Changes to be committed: new file: configs/samples/beagle.conf.sample new file: configs/samples/dnsmgr.conf.sample new file: configs/samples/echolink.conf.sample new file: configs/samples/extensions.conf.sample new file: configs/samples/gps.conf.sample new file: configs/samples/iax.conf.sample new file: configs/samples/logger.conf.sample new file: configs/samples/manager.conf.sample new file: configs/samples/modules.conf.sample new file: configs/samples/savenode.conf.sample new file: configs/samples/voter.conf.sample Changes not staged for commit: modified: configs/samples/beagle.conf.sample modified: configs/samples/echolink.conf.sample deleted: configs/samples/extensions.conf.sample deleted: configs/samples/logger.conf.sample deleted: configs/samples/manager.conf.sample deleted: configs/samples/modules.conf.sample deleted: configs/samples/savenode.conf.sample deleted: configs/samples/iax.conf.sample
modified: configs/samples/beagle.conf.sample modified: configs/samples/echolink.conf.sample deleted: configs/samples/extensions.conf.sample deleted: configs/samples/iax.conf.sample deleted: configs/samples/logger.conf.sample deleted: configs/samples/manager.conf.sample deleted: configs/samples/modules.conf.sample deleted: configs/samples/savenode.conf.sample
modified: configs/samples/gps.conf.sample
modified: configs/samples/gps.conf.sample
| [general] | ||
|
|
||
| [1] | ||
| carrierfrom = hwinvert |
There was a problem hiding this comment.
All these settings need to be documented as to what all the possible options are and what they mean.
Same for all files.
Section names also need to be explained.
There was a problem hiding this comment.
I don't know the beagle board. Someone other than me will have to resolve this.
| @@ -0,0 +1,17 @@ | |||
| [general] | |||
There was a problem hiding this comment.
If there are no general settings, there should be a comment saying there are none but this section name is reserved
There was a problem hiding this comment.
I don't know the beagle board. Someone other than me will have to resolve this.
| gain = 3 ; Antenna Gain | ||
| dir = 0 ; Antenna Direction | ||
|
|
||
| ; ehlert = |
Add sample files to configs.
Closes issues #312 and #316