Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs for missing options #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update configs for missing options #357

wants to merge 1 commit into from

Conversation

KB4MDD
Copy link
Collaborator

@KB4MDD KB4MDD commented Jul 12, 2024

This updates simpleusb and usbradio config files for missing parallel port options.

This updates simpleusb and usbradio config files for missing parallel port options.
@KB4MDD KB4MDD requested a review from tsawyer July 12, 2024 12:53
@tsawyer tsawyer requested review from jxmx and Allan-N July 12, 2024 14:00
@tsawyer
Copy link
Member

tsawyer commented Jul 12, 2024

Have we sorted out how to get config file changes out to users?

@Allan-N
Copy link
Collaborator

Allan-N commented Jul 12, 2024

Have we sorted out how to get config file changes out to users?

AFAIK, we have not yet figured this out. @jxmx, any thoughts?

Copy link
Collaborator

@Allan-N Allan-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (doc) changes are fine.

@jxmx
Copy link
Member

jxmx commented Jul 12, 2024

I think we need to have a larger, strategic discussion on what problem(s) we're trying to architect for when we're talking about "getting config file changes out to users". For this fix, I think it should just be merged and appear in the next release when needed. I would assume that the user base which needs an actual parallel port in 2024 is vanishingly small AND that user base that is nursing equipment along that still has one should be able to edit a text file.

In general, we should likely talk about breaking up some of these monolithic configuration files and make good use of the include ability inside the configuration files. And since Asterisk seems to properly obey "last directive wins" we could create a set of includes that are marked "DO NOT EDIT THIS" and then forcefully blow them away on upgrades with a postinst script when we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants