Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad JS can make it impossible to disable a broken hack. #2

Closed
shaneargo opened this issue Sep 5, 2017 · 1 comment
Closed

Bad JS can make it impossible to disable a broken hack. #2

shaneargo opened this issue Sep 5, 2017 · 1 comment

Comments

@shaneargo
Copy link
Member

If you create a hack that breaks the drop down menus, it becomes impossible to open the drop down to disable the broken hack, thus making it impossible to fix.

Two possible solutions are:

  1. Have a kill switch which disables all enabled hacks. Make sure the button is accessible without javascript.
  2. Do not inject hacks into the JS Hack configuration pages.
@shaneargo
Copy link
Member Author

Fixed by commit 1503ef3 which enables the administrator to suspend injection with the click of a button.

Also fixed by commit d061b7c which automatically restricts injection to pages outside of JS Hack, allowing you to disable an offending packaged even if the dropdowns would otherwise be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant