fix UnknownEndpoint exception not thrown in Node14(aws#3393)

AllanZhengYP · Aug 13, 2020 · c5cd31f · c5cd31f
1 parent 82c0f59
commit c5cd31f
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 1 deletion.
diff --git a/.changes/next-release/bugfix-ErrorParser-eb144db2.json b/.changes/next-release/bugfix-ErrorParser-eb144db2.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "ErrorParser",
+  "description": "fix UnknownEndpoint exception not thrown in Node14(#3393)"
+}
diff --git a/lib/event_listeners.js b/lib/event_listeners.js
@@ -494,7 +494,13 @@ AWS.EventListeners = {
     add('EXTRACT_REQUEST_ID', 'extractError', AWS.util.extractRequestId);
 
     add('ENOTFOUND_ERROR', 'httpError', function ENOTFOUND_ERROR(err) {
-      if (err.code === 'NetworkingError' && err.errno === 'ENOTFOUND') {
+      function isDNSError(err) {
+        return err.errno === 'ENOTFOUND' ||
+          typeof err.errno === 'number' &&
+          typeof AWS.util.getSystemErrorName === 'function' &&
+          ['EAI_NONAME', 'EAI_NODATA'].indexOf(AWS.util.getSystemErrorName(err.errno) >= 0);
+      }
+      if (err.code === 'NetworkingError' && isDNSError(err)) {
         var message = 'Inaccessible host: `' + err.hostname +
           '\'. This service may not be available in the `' + err.region +
           '\' region.';

diff --git a/lib/node_loader.js b/lib/node_loader.js
@@ -19,6 +19,7 @@ util.clientSideMonitoring = {
   configProvider: require('./publisher/configuration'),
 };
 util.iniLoader = require('./shared-ini').iniLoader;
+util.getSystemErrorName = require('util').getSystemErrorName;
 
 var AWS;
 

diff --git a/test/event_listeners.spec.js b/test/event_listeners.spec.js