feat: Catch auth session between requests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth module is now cached and reused for folloup registry requests. Previously each request to registry initialized a new session which lead to reset the access token and need of establish secret session all over again. This is now fixed and leads to huge performance improvement when making multiple queries to a registry. JIRA: ISV-4429 Signed-off-by: Ales Raszka <araszka@redhat.com>
|
Fixes #15 |
|
@staticf0x @mantomas Please review. Here are some stats for comparison when getting manifest for 400 tags: |
|
Makes sense to me, good speed-up 👍🏻 |
|
LGTM, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth module is now cached and reused for folloup registry requests.
Previously each request to registry initialized a new session which lead to reset the access token and need of establish secret session all over again. This is now fixed and leads to huge performance improvement when making multiple queries to a registry.
JIRA: ISV-4429