fix: Add session retries to constructor to avoid starting new connections #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticf0x
force-pushed
the
session-retries
branch
from
41c7abf
to
f8b3a93
Compare
Allda
reviewed
Jan 18, 2024
|
Can you please use following commit message formats in order to automatically generate changelog and release package https://www.conventionalcommits.org/en/v1.0.0/ |
staticf0x
force-pushed
the
session-retries
branch
from
f8b3a93
to
58259f3
Compare
staticf0x
changed the title
Allda
approved these changes
Jan 18, 2024
staticf0x
force-pushed
the
session-retries
branch
from
58259f3
to
61901a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
utils.add_session_retries(self.session)during_get_session, which is called in_getcausesurrlib3to start a new connection every time, leading to wasted resources and drops in performance. Calling it once on the session prevents this.