Probapoly init and CVecorder performance improvements #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awonak
approved these changes
Jul 24, 2022
remove self.showLoadingScreen() Co-authored-by: Adam Wonak <adam.wonak@gmail.com>
separated into multiple lines for easier reading Co-authored-by: Adam Wonak <adam.wonak@gmail.com>
mjaskula
approved these changes
Aug 3, 2022
| lower: 3 | ||
| automatically calculated pattern length: 6 | ||
|
|
||
| ### 4:3 Four over Three (Pass the god damn butter) |
There was a problem hiding this comment.
[question] I feel like this is a joke that I don't get, but want to.
There was a problem hiding this comment.
"Pass the god damn butter" is a common mnemonic phrase used when learning to play 4 over 3. Google it and then try and do it by clicking your fingers or knocking on a desk - it is quite rewarding!
|
I just tested both scripts, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for probapoly.
CVecorder: Updated loading screen to show progress to avoid a perception of a hang during load. Reduced number of save-state loading retries for faster loading. Fixed bug that caused recordings to be buggy if no save state file was found.