Add additional documentation for the use of custom images on the oled. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added section about custom images
Added extra tips for custom images
Added information about Screen burn in
mjaskula
requested changes
Nov 15, 2022
There was a problem hiding this comment.
Hello, thanks for your PR. It's always great to have some documentation updates. If you haven't yet, pleas read the contributing guide so that you know what to expect during your PR.
This one looks pretty good to me. I highlighted a couple typos to be corrected, and opened a discussion on the image used in the example. Once we have these resolved we can get this merged. Thanks again for your contribution. I hope that there will be more.
Changed image bytearray and fixed typos
fixed another typo
fixed another typo
mjaskula
approved these changes
Nov 15, 2022
|
LGTM, thanks for adding to the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional documentation for the use of custom images on the oled display and also addresses potential screen burn in as mentioned here: #83