Add sequential switch #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisib
changed the title
added 3 commits
February 13, 2023 17:01
mjaskula
requested changes
Feb 17, 2023
There was a problem hiding this comment.
This code looks pretty good to me. The functionality itself pushes up against the boundary of what the hardware can do, but I think that the result will still be useful. Thank you for the contribution.
I left a few comments on some minor cleanup, and requested one documentation change. Otherwise I think it's ready to merge.
mjaskula
reviewed
Feb 17, 2023
mjaskula
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Sequential Switch: a 2-6 output sequential switch with support for button & trigger advancement + random ordering