Remove side effecting list comprehensions #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the list comprehensions are turning off all the CV outputs. It seemed to me that having a function that just does that will save some future copy-pasting
mjaskula
approved these changes
May 31, 2023
| sleep_ms(10) | ||
| if self.gate_mode: | ||
| # Only turn off clock triggers. |
There was a problem hiding this comment.
[Question] Why remove this comment?
There was a problem hiding this comment.
That was over-zealous deletion. I'll re-instate that comment, and the deleted one below it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small cleanup pull to remove list comprehensions that exist solely for their side effects. The removed list comprehensions have been replaced with for loops or calls to a new utility function in the firmware,
turn_off_all_cvs.