Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C1 to schematic file and PDF #286

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add C1 to schematic file and PDF #286

merged 1 commit into from
Jul 19, 2023

Conversation

roryjamesallen
Copy link
Collaborator

C1 was previously missing on the schematic as pointed out in #285

mjaskula
mjaskula approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@mjaskula mjaskula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test representation of the changes to the kicad files makes sense to me, and the only change I see to the pdf is the missing C1. So this looks right to me.

@roryjamesallen roryjamesallen merged commit fe99547 into Allen-Synthesis:main Jul 19, 2023
3 checks passed
@roryjamesallen roryjamesallen mentioned this pull request Jul 19, 2023
Closed
@roryjamesallen roryjamesallen deleted the add-c1-to-schematic branch February 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjaskula mjaskula mjaskula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roryjamesallen @mjaskula