Log bootloader exceptions to a file #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjaskula
requested changes
Jan 30, 2024
| # Log the crash to a file for later analysis/recovery | ||
| try: | ||
| with open("last_crash.log", "w") as log_file: | ||
| log_file.write(f"{time.ticks_ms()}: {err}\n") |
There was a problem hiding this comment.
[required] As written this code provides very little information in the log file, just the timestamp and error message. Since we're not constrained to the screen here, we should at least print the traceback with:
sys.print_exception(err, log_file)See https://docs.micropython.org/en/v1.20.0/library/sys.html#sys.print_exception
|
X-post from discord:
|
mjaskula
approved these changes
Jan 31, 2024
chrisib
added a commit
to chrisib/EuroPi
that referenced
this pull request
Feb 2, 2024
* In the case of a bootloader exception, log the exception to last_crash.log * Print the longer exception data to the file too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a bootloader exception, log the exception to
last_crash.logTo prevent the log from growing too much we just re-create the file, so only the last exception is ever saved.
This should resolve #140 and effectively re-implements the work that was closed in #302, though with only the last crash being recorded instead of a constantly-growing log file.