Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Avoid FssSpec bug #468

Closed
wants to merge 1 commit into from
Closed

Conversation

SeanLeRoy
Copy link
Collaborator

@SeanLeRoy SeanLeRoy commented Mar 16, 2023

Description of Changes

Resolves #431 where the minimum allowable fssspec version had potential to cause various errors.

Testing

Ran unit tests locally with minimum allowable version and most current version of fssspec

@SeanLeRoy SeanLeRoy self-assigned this Mar 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -27.44 ⚠️

Comparison is base (6dac4f3) 94.03% compared to head (8876214) 66.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #468       +/-   ##
===========================================
- Coverage   94.03%   66.59%   -27.44%     
===========================================
  Files          48       48               
  Lines        4155     4155               
===========================================
- Hits         3907     2767     -1140     
- Misses        248     1388     +1140     

see 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SeanLeRoy SeanLeRoy closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fsspec dependency to have a hard requirement on >= 2022.8.1
2 participants