Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Restrict tifffile version for now #472

Merged

Conversation

SeanLeRoy
Copy link
Collaborator

@SeanLeRoy SeanLeRoy commented Mar 21, 2023

Description

This pull request restricts the version of tifffile to be less than version 2023.3.15 until the breaking changes can be addressed as it is currently causing the test suite to fail. The specific change that seems to be causing this is found here and can be summarized as the following:

Older versions of tifffile used the OME-XML metadata to create series. In the OME model, positions are separate series. The new MMStack parser uses MicroManager metadata to create series. The positions are now part of a single series. It's a breaking change. Maybe this explains your issue?

Example of broken test suite run

Testing

Unit tested locally, recreated virtual environment with fresh installs locally

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +27.53 🎉

Comparison is base (eb42918) 66.55% compared to head (c46a633) 94.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #472       +/-   ##
===========================================
+ Coverage   66.55%   94.08%   +27.53%     
===========================================
  Files          48       48               
  Lines        4162     4162               
===========================================
+ Hits         2770     3916     +1146     
+ Misses       1392      246     -1146     

see 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SeanLeRoy SeanLeRoy marked this pull request as ready for review March 21, 2023 19:57
@SeanLeRoy
Copy link
Collaborator Author

@ianhi Hi, tagging you Ian since I thought another community member might want to give some insight into whether this seems like a breaking change or if you have encountered this with the newest tifffile release

@SeanLeRoy SeanLeRoy merged commit 45ddfd0 into main Mar 23, 2023
@SeanLeRoy SeanLeRoy deleted the bugfix/restrict-tifffile-version-until-breaking-change-fixed branch March 23, 2023 15:47
@ianhi
Copy link
Contributor

ianhi commented Mar 31, 2023

Hi @SeanLeRoy sorry I missed this. I preferentially use aicsimageio over tifffile, given that and the fact the update to tifffile clearly breaks this library I support this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants