Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py3.8 support for newest xarray version #476

Closed
wants to merge 1 commit into from

Conversation

SeanLeRoy
Copy link
Collaborator

@SeanLeRoy SeanLeRoy commented Mar 29, 2023

Description

A main dependency of this package, xarray, dropped support for Python 3.8 in version 2023.02.0. This has caused our upstream tests to fail (see here). Per the conversation in #475 I removed support for Python 3.8 in favor of supporting the newest xarray version.

A version of aicsimageio (4.10.0) has been released announcing end of its support for Python 3.8

Testing

Clean installed locally, unit tested locally

@SeanLeRoy SeanLeRoy self-assigned this Mar 29, 2023
@SeanLeRoy SeanLeRoy marked this pull request as ready for review March 29, 2023 16:21
@SeanLeRoy SeanLeRoy linked an issue Mar 29, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6f873f) 94.11% compared to head (26cd3c6) 94.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          48       48           
  Lines        4197     4197           
=======================================
  Hits         3950     3950           
  Misses        247      247           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all tests pass, seems fine to me. Sad we don't have 3.11 support yet. We should re-run those tests to see if anything has changed on that front.

@toloudis
Copy link
Collaborator

toloudis commented Mar 29, 2023

Assuming all tests pass, seems fine to me. Sad we don't have 3.11 support yet. We should re-run those tests to see if anything has changed on that front.

I think we have an open issue or PR for Python3.11.

Also we should cut a release with as many bugfixes as possible before dropping support for Python3.8. And document it as our last Python 3.8 release . (I see a potential maintenance branch in our future)

@SeanLeRoy
Copy link
Collaborator Author

Also we should cut a release with as many bugfixes as possible before dropping support for Python3.8. And document it as our last Python 3.8 release . (I see a potential maintenance branch in our future)

Should I cut the release now or just hold off on merging this until the bugs we have scheduled are done.

@SeanLeRoy
Copy link
Collaborator Author

Closing for now, will re-open post last python 3.8 supported release

@SeanLeRoy SeanLeRoy closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do something about xarray version issue
4 participants