Admin/drop 3.8 support for newest xarray

[SeanLeRoy]

Description

A main dependency of this package, xarray, dropped support for Python 3.8 in version 2023.02.0. This has caused our upstream tests to fail (see here). Per the conversation in #475 I removed support for Python 3.8 in favor of supporting the newest xarray version.

A version of aicsimageio (4.10.0) has been released announcing end of its support for Python 3.8

Testing

Clean installed locally, unit tested locally

[SeanLeRoy]

Re-opened this now that a release has been published and we can transition out of supporting Python 3.8 and remove the ceiling for the xarray version

[toloudis]

Why do the commit messages for the version bump say 3.9.4 --> 4.10.0? is that just a typo?

Also, shouldn't the release include every merged PR prior to this one?

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (8adac7c) 94.18% compared to head (021d472) 94.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   94.18%   94.20%   +0.01%     
==========================================
  Files          48       48              
  Lines        4265     4279      +14     
==========================================
+ Hits         4017     4031      +14     
  Misses        248      248              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SeanLeRoy]

Why do the commit messages for the version bump say 3.9.4 --> 4.10.0? is that just a typo?

@toloudis Unsure, it seems to represent 4.10.0on pypi and elsewhere in the code.

Also, shouldn't the release include every merged PR prior to this one?

I believe it did, is there one I missed?

[toloudis]

I believe it did, is there one I missed?

#483 is the one that I see.

And I was suspicious of the commit message because of the 3.9.4 which I thought should have been something like 4.9.4 instead.

[SeanLeRoy]

#483 is the one that I see.

Ah yeah I did that merge after I released 3.8 because I was waiting for a reply. I can do another release if you want to include it in the Python 3.8 support

[AetherUnbound]

LGTM!

[SeanLeRoy]

Closing for now, waiting to drop Python3.8 until after this round of bugfixes is complete