-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin: Update deploy process #494
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 94.00% 94.00%
=======================================
Files 48 48
Lines 4371 4371
=======================================
Hits 4109 4109
Misses 262 262 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note, under my new cookiecutter this is made easier from a few things:
-
I use
Just
instead ofmake
. It allows parameters to each task: https://github.com/bioio-devs/bioio/blob/main/Justfile#L64 -
Projects use dynamic versioning where the project version is pulled directly from git tags rather than a static string. https://github.com/bioio-devs/bioio/blob/main/pyproject.toml#L29
-
I no longer auto-generate changelogs using
gitchangelog
since GitHub can do that for us now with the "auto draft release notes" feature thing.
These seem like great ideas, maybe moving to this when we do the refactor would be best?
Ah I think this is what @toloudis was saying too, I can just update the CONTRIBUTING to include that step and remove some stuff from the make task if that seems good with everyone |
Done in commit bc21473 |
Looks good! Thanks for fixing this! |
Description
The tags created from the deploy process were separated from main as seen in the below screenshots (provided by Dan) where orange is
main
. This updates the deploy process to try to avoid an orphaned tag seemingly happening due to thegit commit --amend
step as well as some little QoL updates.Unsure exactly how to test without triggering the GitHub deploy workflow, welcome to any ideas!