Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Update deploy process #494

Merged
merged 2 commits into from
May 17, 2023
Merged

Admin: Update deploy process #494

merged 2 commits into from
May 17, 2023

Conversation

SeanLeRoy
Copy link
Collaborator

Description

The tags created from the deploy process were separated from main as seen in the below screenshots (provided by Dan) where orange is main. This updates the deploy process to try to avoid an orphaned tag seemingly happening due to the git commit --amend step as well as some little QoL updates.

aicsimageio 2023-05-09 10-28-02
aicsimageio 2023-05-09 10-27-33
aicsimageio 2023-05-09 10-27-50

Unsure exactly how to test without triggering the GitHub deploy workflow, welcome to any ideas!

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e0f9b0d) 94.00% compared to head (bc21473) 94.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          48       48           
  Lines        4371     4371           
=======================================
  Hits         4109     4109           
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note, under my new cookiecutter this is made easier from a few things:

  1. I use Just instead of make. It allows parameters to each task: https://github.com/bioio-devs/bioio/blob/main/Justfile#L64

  2. Projects use dynamic versioning where the project version is pulled directly from git tags rather than a static string. https://github.com/bioio-devs/bioio/blob/main/pyproject.toml#L29

  3. I no longer auto-generate changelogs using gitchangelog since GitHub can do that for us now with the "auto draft release notes" feature thing.

@SeanLeRoy
Copy link
Collaborator Author

SeanLeRoy commented May 15, 2023

These seem like great ideas, maybe moving to this when we do the refactor would be best?

I no longer auto-generate changelogs using gitchangelog since GitHub can do that for us now with the "auto draft release notes" feature thing.

Ah I think this is what @toloudis was saying too, I can just update the CONTRIBUTING to include that step and remove some stuff from the make task if that seems good with everyone

@SeanLeRoy
Copy link
Collaborator Author

These seem like great ideas, maybe moving to this when we do the refactor would be best?

I no longer auto-generate changelogs using gitchangelog since GitHub can do that for us now with the "auto draft release notes" feature thing.

Ah I think this is what @toloudis was saying too, I can just update the CONTRIBUTING to include that step and remove some stuff from the make task if that seems good with everyone

Done in commit bc21473

@toloudis
Copy link
Collaborator

Looks good! Thanks for fixing this!

@SeanLeRoy SeanLeRoy marked this pull request as ready for review May 17, 2023 16:15
@SeanLeRoy SeanLeRoy merged commit e1dd349 into main May 17, 2023
98 checks passed
@SeanLeRoy SeanLeRoy deleted the admin/update-deploy-process branch May 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants