LIF image data ordering #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 94.01% 85.65% -8.36%
==========================================
Files 53 53
Lines 4608 4608
==========================================
- Hits 4332 3947 -385
- Misses 276 661 +385
☔ View full report in Codecov by Sentry. |
|
Closing this out for now, the problem is more convoluted than I originally thought, may need to wait for a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intended to resolve #508 where it appeared the channels and timepoints were being swapped around. I was able to reproduce this and it seems the default C-like ordering of the images.
Testing
Let me know if you have some good unit test ideas, I think we'd need a new LIF file to test this appropriately (we can use the one from the discussion, but it would largely be testing nothing). I tested it locally by reading in various LIFs and comparing it against FIJI with different ordering styles.