Allow more channels in metadata than in data #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
requested review from
kmitcham,
toloudis,
evamaxfield and
BrianWhitneyAI
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 93.99% 93.95% -0.04%
==========================================
Files 53 53
Lines 4662 4665 +3
==========================================
+ Hits 4382 4383 +1
- Misses 280 282 +2 ☔ View full report in Codecov by Sentry. |
toloudis
approved these changes
Nov 20, 2023
BrianWhitneyAI
approved these changes
Nov 21, 2023
SeanLeRoy
deleted the
feature/support-more-channels-in-metadata-than-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #532 Suraj has a use case for a file with more channels in the metadata than in the data. This becomes an issue for
xarraysince we give it coordinates for channels that don't exist. Instead, this will now report a warning and just use the first N channels up to the number of channels in the data.Testing
Where I was previously unable to load the image provided in the issue, this now loads and reports the configured warning. Let me know if anyone feels this seems to warrant adding a test file and matching unit test.