Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets: add Range methods to some of widgets #556

Merged
merged 5 commits into from Nov 14, 2022

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Oct 1, 2022

  • StyleSetter
  • ConditionWidget

these widgets are eligable to have Range method
(this allows i.a. RowWidget to be displayed properly)

@gucio321
Copy link
Collaborator Author

gucio321 commented Oct 1, 2022

I need the other PR to make it working (#555) converting to draft now...

@gucio321 gucio321 marked this pull request as draft October 1, 2022 16:31
@gucio321 gucio321 marked this pull request as ready for review November 11, 2022 08:59
@gucio321
Copy link
Collaborator Author

Ok @AllenDang this pr is ready now

@codecov-commenter
Copy link

Codecov Report

Merging #556 (d2572f1) into master (8769e58) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #556      +/-   ##
=========================================
- Coverage    3.06%   3.04%   -0.02%     
=========================================
  Files          32      32              
  Lines        3167    3184      +17     
=========================================
  Hits           97      97              
- Misses       3069    3086      +17     
  Partials        1       1              
Impacted Files Coverage Δ
ExtraWidgets.go 0.00% <0.00%> (ø)
StyleSetter.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AllenDang AllenDang merged commit 126ef9a into AllenDang:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants