Set the column text as the title of the column header #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With small columns, it's not sure the full header text can fit. To account for this case, set the title attribute of the column header to the text of the column header. That way, if the text is not completely visible, hovering the mouse on the header will display the text. This makes the assumption that this.props.children is a string, but that seems to be already the case for the filters seem to expect that. Otherwise, it might be convenient to allow manually setting the title attribute as a property of TableHeaderColumn
|
LGTM |
|
Released on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With small columns, it's not sure the full header text can fit.
To account for this case, set the title attribute of the column header to the text of the column header.
That way, if the text is not completely visible, hovering the mouse on the header will display the text.
This makes the assumption that this.props.children is a string, but that seems to be already the case for the filters seem to expect that.
Otherwise, it might be convenient to allow manually setting the title attribute as a property of TableHeaderColumn