Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules to ignore bad data #984

Closed
wbwakeman opened this issue Sep 10, 2019 · 4 comments
Closed

Update modules to ignore bad data #984

wbwakeman opened this issue Sep 10, 2019 · 4 comments
Assignees

Comments

@wbwakeman
Copy link
Contributor

wbwakeman commented Sep 10, 2019

PBS-1868 records whether to "use_spike_data" and "use_lfp_data" for each probe in the release. Need to update LIMS strategies, and SDK modules for each of the following to ignore probes where these fields are FALSE, as noted for each below:

  • Current source density
    -- Exclude use_lfp_data = FALSE
  • Analysis metrics
    -- Exclude use_spike_data = FALSE
  • LFP Subsampling
    -- Exclude use_lfp_data = FALSE

LIMS strategy work tracked in http://jira.corp.alleninstitute.org/browse/PBS-1870

@NileGraddis
Copy link
Contributor

Here is a mapping from bad data interval type -> modules impacted

stimulus

  • create_stim_table
  • current source density
  • write_nwb
  • analysis metrics (not yet extant)

spike

  • write_nwb
  • analysis metrics (not yet extant)

lfp

  • current source density
  • lfp subsampling
  • write nwb

@sgratiy
Copy link
Contributor

sgratiy commented Sep 12, 2019

@wbwakeman The PR addresses everything except for the Analysis metric module, which does not yet exist.

@sgratiy
Copy link
Contributor

sgratiy commented Sep 12, 2019

@NileGraddis @wbwakeman listed modules affected by "stimulus". I am not sure what is mean by this category. Also, this looks like a different issue.

@sgratiy
Copy link
Contributor

sgratiy commented Sep 12, 2019

Associated PR #995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants