Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

984/ignore bad data #995

Merged
merged 3 commits into from Sep 12, 2019
Merged

984/ignore bad data #995

merged 3 commits into from Sep 12, 2019

Conversation

sgratiy
Copy link
Contributor

@sgratiy sgratiy commented Sep 12, 2019

This PR is a replacement for
PR: Do not save data from the invalid probes #980

when lfp/csd are unavailable for the probe, the corresponding entries
in the input_json should be None
Write lfp data into nwb file only for probes that have lfp data
Add record in the EcephysProbe table to indicate whether probe includes lfp data
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #995 into internal will increase coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff              @@
##           internal     #995      +/-   ##
============================================
+ Coverage     32.06%   32.06%   +<.01%     
============================================
  Files           323      323              
  Lines         31389    31391       +2     
============================================
+ Hits          10066    10067       +1     
- Misses        21323    21324       +1
Impacted Files Coverage Δ
...hys/ecephys_session_api/ecephys_nwb_session_api.py 56.86% <ø> (ø) ⬆️
allensdk/brain_observatory/ecephys/nwb/__init__.py 100% <100%> (ø) ⬆️
...dk/brain_observatory/ecephys/write_nwb/_schemas.py 100% <100%> (ø) ⬆️
...dk/brain_observatory/ecephys/write_nwb/__main__.py 70.37% <40%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e34ff...e6fa132. Read the comment docs.

Copy link
Contributor

@NileGraddis NileGraddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NileGraddis NileGraddis merged commit b848a60 into internal Sep 12, 2019
@kschelonka kschelonka deleted the 984/ignore-bad-data branch October 2, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants