Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vbn notebooks #2523

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

corbennett
Copy link
Contributor

Overview:

Updates to the VBN read the docs page and tutorial notebooks.

Addresses:

Fixes a minor error in the visual_behavior_dataset_manifest notebook (the code was fine but one of the cells had been run out of order producing an apparent error when viewing the html) and updates the documentation to 1) remove reference to the VBO dataset which might have been confusing to users and 2) add a link to the SWDB tutorial notebooks for further help.

Type of Fix:

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • [x ] Documentation Change

Solution:

I just reran the notebook so the cell resolved correctly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Corbett Bennett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aamster aamster self-requested a review August 17, 2022 13:54
Copy link
Contributor

@aamster aamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aamster aamster merged commit a73b9db into AllenInstitute:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants