Modify write nwb methods to instantiate objects using from_lims #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikejhuang
commented
Dec 7, 2022
•
mikejhuang
commented
- Modified write_nwb methods to instantiate objects using from_lims instead of from_json
- Removed json validation in NWB writers.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
morriscb
requested changes
Dec 8, 2022
There was a problem hiding this comment.
This might be overkill but do we want to add checks to make sure that the written NWB, when loaded, matches the from_lims session. Then again, I sort of crooked my head looking at the code that both created the json and then did the from_lims pull to make sure they were the same, which, why were we doing from_json in the first place :D
|
I added the check. I vaguely remember asking about this in the standup but it was easy to add back in anyways. |
mikejhuang
force-pushed
the
ticket/2607/dev_
branch
from
fa4e305
to
1f4a3cf
Compare
morriscb
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.