Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with notebooks #2635

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Fix issues with notebooks #2635

merged 7 commits into from
Dec 14, 2022

Conversation

aamster
Copy link
Contributor

@aamster aamster commented Dec 13, 2022

This PR fixes issues with the notebooks so that all run successfully and the notebook runner workflow job passes.

  • Fixes an issue with ProjectCacheBase

Error case:

    cache.load_manifest(
        'visual-behavior-neuropixels_project_manifest_v0.2.0.json')
    cache.load_latest_manifest()

The last line was not loading the latest metadata tables into memory, since the previous line was loading the old ones.
The fix is to call load_manifest in load_latest_manifest

  • sklearn is called "scikit-learn" on pypi, not "sklearn"
  • bug in visual_behavior_mouse_history notebook: don't modify a property

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aamster aamster marked this pull request as ready for review December 14, 2022 02:05
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aamster aamster merged commit e413cf5 into master Dec 14, 2022
@aamster aamster deleted the fix/load_latest_manifest branch December 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants