Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc/2.15.1: HOTFIX #2652

Merged
merged 1 commit into from
Jan 25, 2023
Merged

rc/2.15.1: HOTFIX #2652

merged 1 commit into from
Jan 25, 2023

Conversation

morriscb
Copy link
Contributor

Fix bug in stimulus_presentations loading.
Fix backwards compatibility for VBN release.

@morriscb morriscb marked this pull request as ready for review January 24, 2023 23:33
@morriscb morriscb requested a review from aamster January 24, 2023 23:33
@morriscb
Copy link
Contributor Author

Tested pulling manifest version 0.3. Branch is now backwards compatible.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

aamster
aamster previously approved these changes Jan 25, 2023
Copy link
Contributor

@aamster aamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, it couldn't hurt to add doc as to why those checks are there. In what version of the data were those fields added and in which versions won't it be included?

aamster
aamster previously approved these changes Jan 25, 2023
Fix stimulus_block typo.
Add extra check for file id in probes search.
Bump version.
Fix Data Change formating.
Update notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants