Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue with loading trials from BehaviorEcephysSession.from_nwb #2701

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fixes issue with loading trials from BehaviorEcephysSession.from_nwb #2701

merged 1 commit into from
Jul 19, 2023

Conversation

aamster
Copy link
Contributor

@aamster aamster commented Jul 19, 2023 •
edited

Fixes #2490

This issue was thought to be fixed. However there was a regression that wasn't tested. We only tested for the from_json API.

Testing

Added unit test and manually tested with

from pynwb import NWBHDF5IO
from allensdk.brain_observatory.ecephys.behavior_ecephys_session import (
BehaviorEcephysSession)

path=r"/allen/programs/mindscope/workgroups/np-behavior/vbn_data_release/vbn_s3_cache/visual-behavior-neuropixels-0.4.0/behavior_ecephys_sessions/1044594870/ecephys_session_1044594870.nwb"

with NWBHDF5IO(path, 'r', load_namespaces=True) as nwb_io:
    session = BehaviorEcephysSession.from_nwb(nwbfile=nwb_io.read())

session.get_rolling_performance_df()

@aamster aamster requested a review from morriscb July 19, 2023 14:52
morriscb
morriscb approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aamster aamster merged commit 56d1423 into master Jul 19, 2023
12 of 13 checks passed
@aamster aamster deleted the ticket-2490_2 branch July 19, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscb morriscb morriscb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'change_time_no_display_delay' key in trial table breaks session.get_rolling_performance_df() method
2 participants
@aamster @morriscb