Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticket/PSB-173: Create allensdk_anaconda3 image in Pika dockerhub. Modify Bamboo script #2708

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

morriscb
Copy link
Contributor

Update the docker image for anaconda3 to latest version of miniconda. Remove python3.6 and add python3.10, 3.11.

Increment AllenSDK version in anticipation of updated pypi deployment.

@morriscb morriscb requested a review from aamster July 27, 2023 18:39
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

aamster
aamster previously approved these changes Jul 28, 2023
@@ -1,7 +1,10 @@
# docker build --tag alleninstitute/allensdk:anaconda3 .
# docker run -it alleninstitute/allensdk:anaconda3 /bin/bash
#
FROM continuumio/miniconda3:4.8.2
# To deploy an image for use on bamboo, use the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the above not relevant then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct. I'll remove the two of them.

aamster
aamster previously approved these changes Jul 31, 2023
# docker buildx build --platform linux/amd64,linux/arm64 -t alleninstitutepika/allensdk_anaconda3 --push docker/anaconda3
#
# To pull the container:
# docker run -it alleninstitutepika/allensdk:anaconda3 /bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not correct. should be alleninstitutepika/allensdk_anaconda3

aamster
aamster previously approved these changes Jul 31, 2023
Increment version.
Add comment on deploying to bamboo.
Update notebooks
@morriscb morriscb merged commit 028a9e6 into master Jul 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants