rc/2.16.1 #2735
Merged
rc/2.16.1 #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Update nightly runner location. Change to home wildcard. Fix path
Hotfix
Fix readthedocs formating Change readthedocs version. Update doc requirements.
aamster
previously approved these changes
Nov 13, 2023
| @@ -77,7 +77,7 @@ jobs: | |||
| - name: run test in docker | |||
| run: | | |||
| docker run \ | |||
| --env-file /home/github_worker/env.list \ | |||
| --env-file ~/env.list \ | |||
There was a problem hiding this comment.
just curious why this needed to be changed? Due to moving VM to platform9?
There was a problem hiding this comment.
Yes, this change makes it compatible with both workers. The current one has /home/github_worker while the platform 9 VM uses /local1/github_worker. "~/" maps to either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update testing host location.
Fix bug in retrieving change time in trials.
Update notebooks with full true cache location.
docs now building successfully: https://allensdk--2735.org.readthedocs.build/en/2735/
Copied most of the versions in the doc_requirements.txt file from the main requirements.txt file.