960/ecephys rf metrics #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsiegle - did the value of the metrics change or did you just reactor some code? If all you did was some refactoring then we can run the unit tests and they should all pass, since they already include check for the receptive field values. However you'll have to wait because the unit tests have not been merged into internal. |
|
@kaeldai yes, the outputs will change. The original metrics were in units of pixels (0-8) and now they are in units of degrees relative to the mouse's center of gaze. |
…into 960/ecephys_rf_metrics Conflicts: allensdk/brain_observatory/ecephys/stimulus_analysis/receptive_field_mapping.py
960/ecephys rf metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #960