Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonLinearCoordinateTransform transformId deserialization bug #81

Closed
RussTorres opened this issue Apr 17, 2018 · 1 comment
Closed

NonLinearCoordinateTransform transformId deserialization bug #81

RussTorres opened this issue Apr 17, 2018 · 1 comment
Labels
bug priority: high

Comments

@RussTorres
Copy link
Collaborator

A good fix for this would probably also resolve #80, but documenting separately while I think about that. The current implementation of renderapi.transform.NonLinearCoordinateTransform will, when given a json dictionary, load the proper attributes and then overwrite transformId with the argument value (default None). This is problematic for dereferencing transformations and probably should have a test.
RussTorres added a commit to RussTorres/render-python that referenced this issue Apr 17, 2018
@RussTorres
test: add test for AllenInstitute#81
9ce45e2
RussTorres added a commit to RussTorres/render-python that referenced this issue Apr 17, 2018
@RussTorres
transform: quick resolution to AllenInstitute#81
272e5eb
fcollman pushed a commit that referenced this issue Apr 17, 2018
@RussTorres @fcollman
test: add test for #81
d5e271d
fcollman pushed a commit that referenced this issue Apr 17, 2018
@RussTorres @fcollman
transform: quick resolution to #81
a238e96
@fcollman
Copy link
Member

resolved with #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcollman @RussTorres