Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 56 run indexer #58

Merged
merged 3 commits into from
May 28, 2024
Merged

Feat 56 run indexer #58

merged 3 commits into from
May 28, 2024

Conversation

helen-m-lin
Copy link
Contributor

closes #56

  • updated run.sh
  • updated AindIndexBucketJobSettings.from_param_store to pull docdb job settings from aws secrets manager

At minimum, the parameter in aws parameter store should have:

{
  "doc_db_secret_name": "{docdb_secret_name}",
  "doc_db_db_name": "metadata_index",
  "doc_db_collection_name": "data_assets",
  "s3_buckets": [
    "{bucket1}",
    "{bucket2}",
    ...
  ]
}

helen-m-lin
helen-m-lin commented May 28, 2024
View reviewed changes
src/aind_data_asset_indexer/run.sh
@@ -1,3 +1,3 @@
#!/bin/bash

python src/aind_data_asset_indexer/s3_crawler.py && python src/aind_data_asset_indexer/update_docdb.py
python src/aind_data_asset_indexer/index_aind_buckets.py --param-store-name $PARAM_STORE_NAME
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumes $PARAM_STORE_NAME has been set to env vars.

jtyoung84
jtyoung84 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@jtyoung84 jtyoung84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check that the role has permissions to both the parameter and the secrets

@helen-m-lin helen-m-lin merged commit 102b639 into main May 28, 2024
3 checks passed
@helen-m-lin helen-m-lin deleted the feat-56-run-indexer branch May 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefmaru yosefmaru yosefmaru approved these changes

@jtyoung84 jtyoung84 jtyoung84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run AIND bucket indexer on a schedule (twice a day)
3 participants
@helen-m-lin @yosefmaru @jtyoung84