Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

390 input checking for settings files #503

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

rachelstephlee
Copy link
Contributor

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

Error checking for Setting_box csvs:

  1. Check that there is a newline at the end of the csv file
  2. Check that mandatory fields are in csv file.

What issues or discussions does this update address?

Issue 390.

Describe the expected change in behavior from the perspective of the experimenter

Better error checking so Bonsai doesn't crash immediately when the settings_box.csv file is not formatted correctly.

Describe any manual update steps for task computers

None.

Was this update tested in 446/447?

No.

@alexpiet
Copy link
Collaborator

alexpiet commented Jun 6, 2024

@rachelstephlee Looks great, I will test it in 447 before approving

@alexpiet alexpiet merged commit 0a5dd7f into develop Jun 11, 2024
@alexpiet alexpiet mentioned this pull request Jun 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants