Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAdminOn no longer makes sense with a JS app style admin #52

Closed
scottwalters opened this issue May 8, 2019 · 1 comment
Closed

isAdminOn no longer makes sense with a JS app style admin #52

scottwalters opened this issue May 8, 2019 · 1 comment

Comments

@scottwalters
Copy link

ack says there are 63 references to isAdminOn still floating around. At a glance, it's things like showing the clipboard and the trash and reducing cache timeouts. Except reducing cache timeouts, all or most of those other things should be replaced with webservice endpoints. The admin should handle viewing and emptying the trash and stuff like that. I'm sure these are things that Doug would have moved to the admin if he'd gotten to them.

The admin should turn admin mode on the site on and off when it launches and is closed. 7fbf151 added an API endpoint to let it do that. That is still useful for disabling (or nearly disabling) caching and similar things.

Other things like trash need APIs written for them.

From WebGUI::Asset::Redirect displays decision page even when admin mode is turned off #49

@scottwalters
Copy link
Author

Oops, was trying to salvage bits of the other ticket before closing it, but that was the major part of it. Redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant