Clear session before redirecting.

This fixes an infinite redirect loop that would happen when a token expires.
AlloyCI · May 21, 2018 · a1a56e2 · a1a56e2
1 parent 6bb1757
commit a1a56e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/lib/alloy_ci/web/controllers/admin/user_controller.ex b/lib/alloy_ci/web/controllers/admin/user_controller.ex
@@ -29,6 +29,7 @@ defmodule AlloyCi.Web.Admin.UserController do
 
   def auth_error(conn, {_, _}, _opts) do
     conn
+    |> clear_session()
     |> put_flash(:error, "Admin Authentication required")
     |> redirect(to: admin_login_path(conn, :new))
   end

diff --git a/lib/alloy_ci/web/controllers/auth_controller.ex b/lib/alloy_ci/web/controllers/auth_controller.ex
@@ -77,6 +77,7 @@ defmodule AlloyCi.Web.AuthController do
 
   def auth_error(conn, {_, _}, _opts) do
     conn
+    |> clear_session()
     |> put_flash(:error, "Authentication required")
     |> redirect(to: auth_path(conn, :login, :login))
   end