Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startrails Program Doesn't Accept Brightness parameter #613

Closed
jryd2000 opened this issue Oct 8, 2021 · 4 comments · Fixed by #616
Closed

Startrails Program Doesn't Accept Brightness parameter #613

jryd2000 opened this issue Oct 8, 2021 · 4 comments · Fixed by #616

Comments

@jryd2000
Copy link

jryd2000 commented Oct 8, 2021

The startrails program does not appear to accept the -b brightness parameter and only used the default value stored in the program.

@linuxkidd
Copy link
Collaborator

@jryd2000 can you provide the command issued, as well as the console output from startrails to help us narrow down the issue?

Looking at the current source, it does appear to make use of the brightness option, so I'm hope'n the output you provide can give us some clues.

Thanks!

@jryd2000
Copy link
Author

jryd2000 commented Oct 8, 2021

I believe I identified the issue. The long_options struct in startrails.cpp near the top was missing the argument for “b” so it wasn’t reading the argument. When I added to my local copy it started working.

@linuxkidd
Copy link
Collaborator

Right you are! I'm fixing it now and submitting a PR. Nice find, thanks!

@linuxkidd
Copy link
Collaborator

As soon as @EricClaeys or @ckuethe review the PR, it'll merge and fix this for everyone. Thanks again!

ckuethe added a commit that referenced this issue Oct 8, 2021
Added missing 'brightness' param to config struct.  Resolves #613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants