Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes as requested on #2717 #2727

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

Alex-developer
Copy link
Collaborator

  • Allow the number of images to process to optionally be passed as an argument (to flow_runner.py ?). The default can remain at 10.

Added --flowtimerframes option to flow-runney.py Default is 10

  • Add a variable to allsky/variables.sh to define the directory, e.g., ALLSKY_FLOWTIMINGS. This will make it easy for check_allsky.sh to find the directory.

Added the following variables
ALLSKY_FLOWTIMINGS="${ALLSKY_TMP}/flowtimings"
ALLSKY_FLOWTIMINGS_DAY="${ALLSKY_FLOWTIMINGS}/day-average"
ALLSKY_FLOWTIMINGS_NIGHT="${ALLSKY_FLOWTIMINGS}/night-average"

  • How will check_allsky.sh know the names of the files? Should other variables be added, e.g., ALLSKY_FLOWTIMINGS_XXX ?

See above

  • allsky/allsky.sh should rm -fr "${ALLSKY_FLOWTIMINGS}" so we know any files are from the current instance of Allsky.

New option --cleartimings added to flow-runner.py. This is called from allsky.sh to clear all timing data

  • Please make times stored in the files in integer milliseconds.

Values are now ints

@Alex-developer Alex-developer merged commit d5ce7fd into AllskyTeam:dev May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant