Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid numbers #2744

Merged
merged 9 commits into from
Jun 4, 2023
Merged

Check for valid numbers #2744

merged 9 commits into from
Jun 4, 2023

Conversation

EricClaeys
Copy link
Collaborator

If a user enters an invalid number, e.g., not [+-0-9,.] display an error message and don't update the settings file.
Also, if one of the settings that are used to determine the time between images display is invalid, also display an error message.

If initialize_variables() or another global function called by index.php sets an error message, display it.
Without this check, if a user entered a non-numeric value, the math with fail.
If a caller wants to highlight the table of messages it can set the new $highlight argument which puts a border around the table and add a line at the top and bottom.
If an error was generated by a function that's not for a particular page, display the message(s) in "highlight" mode.
* Check for legal numbers.
* Reset $key rather than use $originalName to make it more obvious what's happening.
* Display message more efficiently.
@EricClaeys EricClaeys merged commit ea1420c into dev Jun 4, 2023
@EricClaeys EricClaeys deleted the Check-for-valid-numbers branch June 4, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant