Removed debug "echo" #434
Merged
Removed debug "echo" #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And removed some unneeded commented-out lines.
|
Thomas,
Whatever you did with allsky and allsky-portal allowed me to fix the out-of-sync issue. They were both behind your fork, not ahead, so I simply merged your changes into mine.
My allsky-website is still 9 commits ahead of yours so I can’t your changes in.
Going forward, I will issue PRs against your repository, but will never merge them myself. I always want someone else to take a look. If I ever have a huge number of changes at once and want to be able to send them to people for testing (like Linda and my changes), I’ll use my fork.
Thanks - Eric
From: Thomas Jacquin ***@***.***>
Sent: Sunday, August 15, 2021 7:26 PM
To: thomasjacquin/allsky ***@***.***>
Cc: EricClaeys ***@***.***>; Author ***@***.***>
Subject: Re: [thomasjacquin/allsky] Removed debug "echo" (#434)
Merged #434 <#434> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#434 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT2PYK5XANU3LG6IHYAOANDT5BLJPANCNFSM5CGWIVQA> .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> . <https://github.com/notifications/beacon/AT2PYK4AZQNGPPX46U2O6L3T5BLJPA5CNFSM5CGWIVQKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGPAAAAAAJTSQCVQ.gif>
|
|
Nice! That's a good plan. Regarding the allsky-image repo, I can take a look when you're ready to push a new feature. There might be some kind of conflict in one of the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And removed some unneeded commented-out lines.