add filtering on image size to startrail and keogram generation #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also mitigates #492 because then I can exclude the notification images. |
EricClaeys
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
This only mitigates #492 when the width and height are non-zero, which I don't think is very often.
492 still needs to be fixed, so please don't close it when you merge this code.
Once we know the current camera's capabilities we can set the width and height in the configuration file to the camera's max width and height, then have removeBadImages also use the JQ trick to weed out bad images.
|
Oh, I see what you mean by when h/w != 0. As in... user has specified them. Sure, I'll leave 492 open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probable fix for #547 and #539