Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveImage.sh bugfix - creating image.jpg #939

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

EricClaeys
Copy link
Collaborator

When not saving daytime images, image.jpg wasn't getting updated.

When not saving daytime images, image.jpg wasn't getting updated.
@EricClaeys EricClaeys added the bug needs software change label Jan 17, 2022
@linuxkidd linuxkidd merged commit 5cdf9b0 into master Jan 17, 2022
@AndreasLMeg
Copy link
Collaborator

I think this is buggy (but not testet):

If you move the file ${IMAGE_TO_USE}, later use will fail
e.g.

...
mv "${IMAGE_TO_USE}" "${WORKING_DIR}/${FULL_FILENAME}"	# Websites look for $FULL_FILENAME
...
convert "${IMAGE_TO_USE}" -resize "${RESIZE_UPLOADS_SIZE}" -gravity East -chop 2x0 "${FILE_TO_UPLOAD}"

@EricClaeys EricClaeys deleted the saveImage.sh-image.jpg-bug branch January 18, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs software change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants