upload.sh: minor changes #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved some code only used by FTP protocol into that section.
For debugging, added $TEMP_NAME to debug output. On very slow networks it's possible for multiple lftp's to be happening at once, which can cause problems. Adding $TEMP_NAME helps debug that. Really should only allow one lftp per file, e.g., one for "image.jpg".
If a password has "!!" in it, it's interpreted as shell job history, so use "set +H" to turn that off. Really want to disable ALL special character processing in ${REMOTE_PASSWORD}, but don't know how.
linuxkidd
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some code only used by FTP protocol into that section.
For debugging, added $TEMP_NAME to debug output. On very slow networks it's possible for multiple lftp's to be happening at once, which can cause problems. Adding $TEMP_NAME helps debug that. Really should only allow one lftp per file, e.g., one for "image.jpg".
If a password has "!!" in it, it's interpreted as shell job history, so use "set +H" to turn that off. Really want to disable ALL special character processing in ${REMOTE_PASSWORD}, but don't know how.