Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Throwables.propagate with RuntimeException in CommonTestUtils.java #41

Closed
yupeng9 opened this issue Sep 28, 2017 · 1 comment

Comments

@yupeng9
Copy link
Contributor

yupeng9 commented Sep 28, 2017

Guava "Throwables.propagate" is deprecated. see reasons in
https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate

This ticket modifies https://github.com/Alluxio/alluxio/blob/master/core/common/src/test/java/alluxio/CommonTestUtils.java#L109
https://github.com/Alluxio/alluxio/blob/master/core/common/src/test/java/alluxio/CommonTestUtils.java#L132
to replace

throw Throwables.propagate(e);

or

Throwables.propagate(e);

with

throw new RuntimeException(e);

Remember also to remove the corresponding import if Throwables becomes unused

import com.google.common.base.Throwables;
@seainm
Copy link

seainm commented Oct 22, 2017

I did it and this is the link to my PE:
Alluxio/alluxio#6321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants