Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PVC for worker tiered store in K8s #11171

Merged
merged 3 commits into from Mar 17, 2020

Conversation

jiacheliu3
Copy link
Contributor

This resolves worker tiered storage using PVC, as point 4 in #10253

The PVC will be satisfied by either hostPath or local under the hood to provide local storage to the worker.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • AmplabJenkins build check: PENDING
    • We were not able to detect AmplabJenkins test results on this PR. Status will update when testing completes.
  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

Comment on lines +134 to +162
# emptyDir example
# - level: 0
# mediumtype: MEM
# path: /dev/shm
# type: emptyDir
# quota: 1G
#
# hostPath example
# - level: 0
# mediumtype: MEM
# path: /dev/shm
# type: hostPath
# quota: 1G
#
# persistentVolumeClaim example
# - level: 1
# mediumtype: SSD
# type: persistentVolumeClaim
# name: alluxio-ssd
# path: /dev/ssd
# quota: 10G
#
# multi-part mediumtype example
# - level: 1
# mediumtype: SSD,HDD
# type: persistentVolumeClaim
# name: alluxio-ssd,alluxio-hdd
# path: /dev/ssd,/dev/hdd
# quota: 10G,10G
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few examples here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiacheliu3 please also update the docs section "Example: Alluxio Storage Management"

@jiacheliu3
Copy link
Contributor Author

I will (rebase and) bump up the version once #11080 is merged.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8827/
Test PASSed.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • AmplabJenkins build check: PASS
  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

All checks passed!

Copy link
Contributor

@madanadit madanadit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiacheliu3!

Comment on lines +134 to +162
# emptyDir example
# - level: 0
# mediumtype: MEM
# path: /dev/shm
# type: emptyDir
# quota: 1G
#
# hostPath example
# - level: 0
# mediumtype: MEM
# path: /dev/shm
# type: hostPath
# quota: 1G
#
# persistentVolumeClaim example
# - level: 1
# mediumtype: SSD
# type: persistentVolumeClaim
# name: alluxio-ssd
# path: /dev/ssd
# quota: 10G
#
# multi-part mediumtype example
# - level: 1
# mediumtype: SSD,HDD
# type: persistentVolumeClaim
# name: alluxio-ssd,alluxio-hdd
# path: /dev/ssd,/dev/hdd
# quota: 10G,10G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiacheliu3 please also update the docs section "Example: Alluxio Storage Management"

#
# persistentVolumeClaim example
# - level: 1
# mediumtype: SSD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is mediumtype MEM possible with pv? If not please explicitly state that in the doc page and why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this PVC's mediumtype should be really depends on what PV it binds to. So it can actually be MEM as hostPath and emptyDir. I put a level 1 SSD here just trying to illustrate it can have level > 0 like being a SSD or HDD.

Is there a particular scenario you are thinking about? Or how do you think this can be illustrated more clearly?

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8843/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8845/
Test FAILed.

@madanadit
Copy link
Contributor

alluxio-bot, test this please.

@alluxio-bot
Copy link
Contributor

alluxio-bot triggering jenkins retest: 0/3

@alluxio-bot
Copy link
Contributor

jenkins, test this please

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8850/
Test PASSed.

@madanadit
Copy link
Contributor

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit 988059f into Alluxio:master Mar 17, 2020
alluxio-bot pushed a commit that referenced this pull request Mar 18, 2020
This change bumps up the helm chart version after a series of K8s
changes are in.
#11171
#11173
#11175

pr-link: #11186
change-id: cid-1fae11b3340986f04297a65880a6af1ab0d5da81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants