Change logserver Deployment update strategy to Recreate

[jiacheliu3]

Addresses #13422

[jiacheliu3]

FYI @nirav-chotai

[codecov-commenter]

Codecov Report

Merging #13423 (eb4a9ea) into master (9f5673e) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #13423      +/-   ##
============================================
- Coverage     43.80%   43.56%   -0.25%     
+ Complexity     8956     8952       -4     
============================================
  Files          1361     1366       +5     
  Lines         78630    79316     +686     
  Branches       9546     9631      +85     
============================================
+ Hits          34443    34553     +110     
- Misses        41277    41846     +569     
- Partials       2910     2917       +7     

Impacted Files	Coverage Δ	Complexity Δ
...a/alluxio/exception/status/CancelledException.java	0.00% <0.00%> (-42.86%)	0.00% <0.00%> (-2.00%)
...e/common/src/main/java/alluxio/AbstractClient.java	59.86% <0.00%> (-12.50%)	20.00% <0.00%> (-4.00%)
.../src/main/java/alluxio/retry/TimeBoundedRetry.java	84.61% <0.00%> (-11.54%)	7.00% <0.00%> (ø%)
.../alluxio/master/journal/AbstractJournalSystem.java	51.21% <0.00%> (-10.55%)	7.00% <0.00%> (ø%)
...uxio/master/FaultTolerantAlluxioMasterProcess.java	48.95% <0.00%> (-8.34%)	10.00% <0.00%> (-4.00%)
...on/src/main/java/alluxio/collections/LockPool.java	74.03% <0.00%> (-6.74%)	15.00% <0.00%> (-1.00%)
...thentication/AuthenticatedChannelServerDriver.java	85.71% <0.00%> (-5.36%)	11.00% <0.00%> (-1.00%)
...ain/java/alluxio/worker/block/BlockMasterSync.java	60.65% <0.00%> (-4.92%)	6.00% <0.00%> (ø%)
...c/main/java/alluxio/heartbeat/HeartbeatThread.java	70.00% <0.00%> (-3.34%)	5.00% <0.00%> (-1.00%)
...c/main/java/alluxio/proxy/AlluxioProxyProcess.java	62.79% <0.00%> (-2.33%)	8.00% <0.00%> (-1.00%)
... and 43 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5673e...eb4a9ea. Read the comment docs.

[madanadit]

Thx!

[nirav-chotai]

@jiacheliu3 , this should not be hardcoded but an option within values.yaml with the default being Recreate

Note should be added:

• If you're using PVC with RWO access mode, then keep the strategy to Recreate. In this case, logserver will be down for some time and logs will be lost for that period of time.
• If you're using PVC with RWX access mode, then keep the strategy to RollingUpdate In this case, logserver will be up and running all the time, so logs will not be lost even while updating logserver.

In our DEV environment, I am planning to keep Recreate strategy with CephRBD and RWO access mode. However, in the PROD environment, I am going to use RollingUpdate strategy with CephFS and RWX access mode.

[ZhuTopher]

LGTM

[LuQQiu]

@jiacheliu3 can this PR be merged?

[jiacheliu3]

@jiacheliu3 can this PR be merged?

@LuQQiu As Nirav mentioned, I think it makes sense to make this a configuration instead of hard code. I will do that and request for another round of reviews.

[jiacheliu3]

@ZhuTopher @madanadit Please take another look after I extracted the field to a configuration. Thanks!

[ZhuTopher]

LGTM

[madanadit]

Thanks @jiacheliu3

[jiacheliu3]

alluxio-bot, merge this please