Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change remote ssh port in alluxio-common.sh #15542

Open
wants to merge 2 commits into
base: master-2.x
Choose a base branch
from

Conversation

zhaoyim
Copy link

@zhaoyim zhaoyim commented May 11, 2022

… all

What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@alluxio-bot
Copy link
Contributor

Hi @zhaoyim, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word must be capitalized
      • First word of title ("15520") is not an imperative verb. Please use one of the valid words

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@alluxio-bot
Copy link
Contributor

You did it @zhaoyim!

Thank you for signing the Contribution License Agreement.

@zhaoyim zhaoyim changed the title 15520 When the linux ssh default port is not 22, the alluxio-start.sh… When the linux ssh default port is not 22, the alluxio-start.sh… May 11, 2022
@zhaoyim zhaoyim changed the title When the linux ssh default port is not 22, the alluxio-start.sh… Add change remote ssh port in alluxio-common.sh May 11, 2022
@@ -10,6 +10,8 @@
# See the NOTICE file distributed with this work for information regarding copyright ownership.
#

PORT=22
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a global var to define the remote ssh port in common.sh. In this way, we just only to change the port once.

Copy link
Contributor

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaoyim Thanks for this contribution! Can you give an example to show how to set the ssh PORT?

Something like PORT=XXX in conf/alluxio-env.sh?

@zhaoyim
Copy link
Author

zhaoyim commented May 30, 2022

Can you give an example to show how to set the ssh PORT?
Something like PORT=XXX in conf/alluxio-env.sh?

Will you mean add the example in the alluxio-common.sh ? I add the example comments on it, could you have a look? Thanks!

@maobaolong
Copy link
Contributor

@zhaoyim Sorry, I mean that alluxio-common.sh is a common tools for alluxio shell framework, but alluxio-env.sh is a config file as well as alluxio-properties, so we should tell user add an env var SSH_PORT in alluxio-env.sh can change the default SSH_PORT.

@zhaoyim
Copy link
Author

zhaoyim commented May 30, 2022

@zhaoyim Sorry, I mean that alluxio-common.sh is a common tools for alluxio shell framework, but alluxio-env.sh is a config file as well as alluxio-properties, so we should tell user add an env var SSH_PORT in alluxio-env.sh can change the default SSH_PORT.

Thanks for your comments! I will move the SSH_PORT into the alluxio-env.sh and changed all the sh source from alluxio-env.sh.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jan 30, 2023
@github-actions github-actions bot removed the stale The PR/Issue does not have recent activities and will be closed automatically label May 16, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The PR/Issue does not have recent activities and will be closed automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants