New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add change remote ssh port in alluxio-common.sh #15542
base: master-2.x
Are you sure you want to change the base?
Conversation
Hi @zhaoyim, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
You did it @zhaoyim! Thank you for signing the Contribution License Agreement. |
@@ -10,6 +10,8 @@ | |||
# See the NOTICE file distributed with this work for information regarding copyright ownership. | |||
# | |||
|
|||
PORT=22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a global var to define the remote ssh port in common.sh. In this way, we just only to change the port once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhaoyim Thanks for this contribution! Can you give an example to show how to set the ssh PORT?
Something like PORT=XXX
in conf/alluxio-env.sh
?
Will you mean add the example in the alluxio-common.sh ? I add the example comments on it, could you have a look? Thanks! |
@zhaoyim Sorry, I mean that |
Thanks for your comments! I will move the SSH_PORT into the alluxio-env.sh and changed all the sh source from alluxio-env.sh. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
… all
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including